Exploring Constructors with C-String and New Char[]

[sysprog]

@yungman please read one or more of @Mark44's AVX 512 Insight articles such as https://www.physicsforums.com/insig...isters-for-conditional-arithmetic-conclusion/. For the benefit of many readers, Mark has written brilliantly and patiently regarding computer programming, including, sometimes especially for you, regarding many specfic things about C++, and you have been helpful numerous times, sometimes just by providing cogent questions. Please let's not forget, and I trust that you don't, what a great guide @Mark44 is ##\dots##

 

[sysprog]

Oh and, I think that @pbuk and @Jarvis323 are worthy of favorable mention, too. I think that real programmers do programming at least partly because they love it ##-## maybe your beloved granddaughter is already a real programmer, @yungman, just as you are a real engineer.

 

[Mark44]

@Mark44 maybe it's archaic of me to do so, but I put a comment on every line of my mainframe or PC assembly language code, even if what the instruction is doing is obvious or should be obvious ##-## I do that based on the it can't hurt principle ##-## if a full explanation is warranted, I'll write it on non-instruction lines ##-## otherwise, I don't see why I should unnecessarily let an unexplained instruction go by.

I put comments on nearly all of the lines of assembly code I write, both in x86 and MIPS (the latter for the class I teach). In high-level language, comments aren't as necessary, provided that you use self-explanatory names. In any case, a comment shouldn't restate what the code is doing -- it's better to say why something is happening.

An example of a useless comment on non-self-documenting code:

l = 80;  // x is set to 80

Better:

const int LINE_LEN = 80;  // Length of a screen line in bytes

 

[sysprog]

And then there are lines that not only shouldn't be commented, but also shouldn't be written in the first place, e.g.

CARDLEN EQU 80 CARDS ARE 80 CHARACTERS LONG

that's a waste of a card.

 

[Jarvis323]

I'll just add that sometimes the act of writing the comments can help you better clarify and understand your own code. And striving to write better comments, by making them more clear, concise, and informative, can also help you gain a more clear and concise understanding.

Also, sometimes comments about a block of code rather than just a line can be helpful.

I often actually start coding up an algorithm by starting with blocks of comments, that enumerate the steps I need to go through. Then I go one by one and add the code corresponding to each block of comments below it. That's just me, but you might try this out if you get stuck sometime.

 

[Vanadium 50]

When I worked in industry, we had a consultant whose advice somehow morphed from "code should have about as many comments as lines" to "every line should have a comment". Needless to say, that didn't help. We got comments like:

++i; // Increments i by 1

and

a = a +b; // Adds b to a

I would also argue that having too many comments is almost as bad as having too few. It causes the important ones to be lost in a sea of trivia. And this from a person who wrote code that had a page or page and a half of comments before the first line of active code. (It was a union of structs, and there was a good reason to do it that way, and the first line of the comment block was a warning not to touch the code without a real good reason).

@Mark44 mentions that comments should tell why, not what. He could have elaborated on this, because it is very good advice. It also dovetails with his earlier advice on picking descriptive variable names. I would consider:

--n; // Decrements n by 1

to be inferior to:

--NumberOfWidgets; //  At this point NumberOfWidgets is one more
                   // than the last Widget. This is needed to fix this.

I think the main exceptions to "tell why not what" is to document side effects or other unexpected or non-obvious behavior:

SpecializedPrint(a,b); // A side effect of Specialized Print is to zero *b

 

[yungman]

Can anyone help me why I have an error on this? I simplified the program to the barebone:

#include <iostream>
#include <cstring>
using namespace std;
class PersonInfo
{ private:     char* name;  int age; const int Nsize = 51;
  public:
   PersonInfo(const char* n, int a) // Constructor
{   name = new char[strlen(n)+1];
   strncpy_s(name, strlen(n) + 1, n, strlen(n) + 1) ;  age = a;}
   PersonInfo(const PersonInfo &obj) // Copy Constructor
   {name = new char[strlen(obj.name)+1];
   strncpy_s(name, strlen(obj.name) + 1, obj.name, strlen(obj.name) + 1);
   age = obj.age;
   }
   ~PersonInfo() { delete[] name; }
};

int main()
{    PersonInfo bob("Bob Faraday", 32);
    PersonInfo clone("clone", 44);
    clone = bob;//copy constructor
    return 0;
}

I had this program, it was working, I don't see any problem. I am blind on this, it's supposed to be simple!

Thanks

 

[Mark44]

I had this program, it was working, I don't see any problem. I am blind on this, it's supposed to be simple!

You have a copy constructor, but you don't have an overloaded assignment operator; i.e., operator=().

The line clone = bob;//copy constructor needs to have operator=(), but you didn't write one.

Also, your comment is wrong -- this line is not calling a copy constructor. A wrong comment is worse than no comment at all.

Also, your code doesn't use Nsize, so why is it there? Even if there is a good reason, it shouldn't be const int in the class definition.

 

[yungman]

You have a copy constructor, but you don't have an overloaded assignment operator; i.e., operator=().

The line clone = bob;//copy constructor needs to have operator=(), but you didn't write one.

Also, your comment is wrong -- this line is not calling a copy constructor. A wrong comment is worse than no comment at all.

Also, your code doesn't use Nsize, so why is it there? Even if there is a good reason, it shouldn't be const int in the class definition.

Thanks for the reply

It's really funny, I have it in my notes that actually ran the program, you can see I can do immediate window. You look at the code, there's no assignment operator. That's where I got tripped. It obviously was working, I got everything.

Thanks

 

[Jarvis323]

Another thing is that your code is formatted in what most people would consider a not-so-great way.

I would usually avoid putting multiple statements on one line. And I would separate statements with whitespace. Also, I would rarely put a statement on the same line as a { or }, unless it's a single line of code.

The idea is to help the reader see how the code is separated individual statements, or highly related sections at a glance, and that makes the code easier to understand quicker. And it also makes you less prone to error as you edit the code.

You might want to try using the autoformatting features of VS.

 

[Mark44]

It's really funny, I have it in my notes that actually ran the program, you can see I can do immediate window. You look at the code, there's no assignment operator. That's where I got tripped. It obviously was working, I got everything.

The part of your code where you show the immediate window doesn't also show main(), so I'm not certain you ran the code you showed a few posts back. The part with main() is below the screen shot with the immediate window. That part also has the same incorrect comment -- "clone = bob;//copy constructor"
Again, this code assumes that you have an overloaded assignment operator -- you don't.
I believe the code you showed a few posts back. I don't believe that the code you have in your notes actually ran without error.

I would usually avoid putting multiple statements on one line.

Strongly agree. @yungman, packing so many statements on one line makes your code hard to follow. Please stop doing this.

And I would separate statements with whitespace. Also, I would rarely put a statement on the same line as a { or }, unless it's a single line of code.

Also very good advice.

 

[sysprog]

It can be hard on the ego to admit it, but I think that in his case it's not really too hard ##-## I'm convinced that Prof. Don is better at programming than I am ##-## thank you for taocp and for ##\mathrm{\TeX},## Professor, which are among the many things for which programmers and others are to be grateful to you, perhaps not the least of which is the concept of literate programming.

 

[Jarvis323]

It can be hard on the ego to admit it, but I think that in his case it's not really too hard ##-## I'm convinced that Prof. Don is better at programming than I am ##-## thank you for taocp and for ##\mathrm{\TeX},## Professor, which are among the many things for which programmers and others are to be grateful to you, perhaps not the least of which is the concept of literate programming.

I've not heard of literate programming. Interesting concept.

 

[yungman]

Hi

I am really out of idea. This is the program I am experimenting. I put const int Nsize = 51; into comment, then it will run. It gave me

#include <iostream>
#include <cstring>
using namespace std;
class PersonInfo
{
  private:   char *name;   int age; //const int Nsize = 51;
  public:
   PersonInfo(const char *n, int a) // Constructor
   {  
        name = new char[strlen(n) + 1];
        strncpy_s(name, strlen(n) + 1, n, strlen(n) + 1);
        age = a;
   }
    PersonInfo(const PersonInfo &obj) // Copy Constructor
    {
        name = new char[strlen(obj.name) + 1];
        strncpy_s(name, (strlen(obj.name) + 1), obj.name, (strlen(obj.name) + 1));
        age = obj.age;
    }
// Accessor functions
    const char* getName() { return name; }
    const int getAge() { return age; }
    ~PersonInfo() { delete[] name; }   // Destructor
};
int main()
{  
    PersonInfo bob("Bob Faraday", 32);
    PersonInfo clone("clone", 44);
    clone = bob;//copy constructor
    cout << " The bob Object contains: " << bob.getName() <<
        ", age = " << bob.getAge() << endl;
    cout << " Clone object name = " << clone.getName() <<
        ", age = " << clone.getAge() << "\n\n";
    return 0;
}

The abort info is this, but you can see the result is out and is correct:

But if I put const int Nsize = 51 back in as shown, it will give me this error:

I don't know how to explain. I am not saying that I don't need operator=(), like Mark suggested. I just want to know why I went this far without it, but adding const int Nsize = 51 blows up everything.

I did make it one code line per line. I just too stuck with the problem.

Thanks
BTW, don't look at my notes to judge on how many lines of code packed into one line. I pack that to save pages and pages extra. That's my own notes, not for anyone else to read, just for me. Or else, it will be over 100 pages!

 

[Jarvis323]

Solution is defining operator=.

Explanation: Like Mark pointed out, line 29 is not calling the copy constructor, it's calling operator=. You didn't define an operator=, so it would use the default one, which just does a shallow copy. Then when both copies go out of scope, they each call delete on the same memory address (in their destructors), which is why you get that runtime error (you should never call delete on the same address twice).

The reason it doesn't compile in the uncommented version is that C++ will "delete"
the default operator= in certain cases, forcing you to either define it yourself or not use it. Having a const member happens to be one of those conditions, as you can see in the below link under the section quoted,

Deleted implicitly-declared copy assignment operator
A implicitly-declared copy assignment operator for class T is defined as deleted if any of the following is true:

• T has a user-declared move constructor;
• T has a user-declared move assignment operator.

Otherwise, it is defined as defaulted.

A defaulted copy assignment operator for class T is defined as deleted if any of the following is true:

• T has a non-static data member of non-class type (or array thereof) that is const;
• T has a non-static data member of a reference type;
• T has a non-static data member or a direct or virtual base class that cannot be copy-assigned (overload resolution for the copy assignment fails, or selects a deleted or inaccessible function);
• T is a union-like class, and has a variant member whose corresponding assignment operator is non-trivial.

https://en.cppreference.com/w/cpp/language/copy_assignment

 

[yungman]

Solution is defining operator=.

Explanation: Like Mark pointed out, line 29 is not calling the copy constructor, it's calling operator=. You didn't define an operator=, so it would use the default one, which just does a shallow copy. Then when both copies go out of scope, they each call delete on the same pointer (in their destructors), which is why you get that runtime error (you should never call delete on the same address/pointer twice).

The reason it doesn't compile in the uncommented version is that C++ will "delete"
the default operator= in certain cases, forcing you to either define it yourself or not use it. Having a const member happens to be one of those conditions, as you can see in the below link under the section quoted,

I am at the process of doing that, I'll be back.

Thanks

 

[sysprog]

@Jarvis323 very nice

 

[sysprog]

@Vanadium 50 also very nice, Sir

 

[sysprog]

@Mark44 you are regularly awesome

 

[yungman]

I put in the operator=() and it works. Don't understand why it worked so far without the operator=().

This is the program:

// This program demonstrates the copy constructor
#include <iostream>
#include <cstring>
using namespace std;

class PersonInfo
{ private:     char* name;  int age; const int Nsize = 51;
  public:
   PersonInfo(const char* n, int a) // Constructor
{   name = new char[Nsize];
   strncpy_s(name, Nsize, n, Nsize) ;  age = a;}
  PersonInfo(const PersonInfo &obj) // Copy Constructor
   {name = new char[Nsize];
   strncpy_s(name, Nsize, obj.name, Nsize);
   age = obj.age;
   }
   PersonInfo& operator=(const PersonInfo& rhs)
   {
       strncpy_s(name, Nsize, rhs.name, Nsize);
       age = rhs.age;
       return *this;
   }
// Accessor functions
  const char *getName() { return name; }
   const int getAge()  { return age; }
   const void printB() { cout << " bob name: " << name
       << ",   (void*)name: " << (void*)name << "\n\n"; }
   const void printC() { cout << " clone name: " << name <<
       ",   (void*)name: " << (void*)name<< "\n\n"; }
   void setName() { strncpy_s(name, Nsize, "delete", Nsize); }
   ~PersonInfo() { delete[] name; }
};
int main()
{    PersonInfo bob("Bob Faraday", 32);
    PersonInfo clone("clone", 44);
    clone = bob;//copy constructor
    cout << " The bob Object contains: " << bob.getName() <<
        ", age = " << bob.getAge() << endl;
    cout << " Clone object name = " << clone.getName() <<
        ", age = " << clone.getAge() << "\n\n";
    bob.setName();
    cout << " The bob Object after setName: " << bob.getName() <<
        ", age = " << bob.getAge() << endl;
    cout << " Clone object after setName = " << clone.getName() <<
        ", age = " << clone.getAge() << "\n\n";
    bob.printB();
    clone.printC();
    return 0;
}

This is the printout from the program:

maybe it's time to move on instead of keep asking why, just follow the rule of Three.

Thanks Mark, Jarvis323 and Sysprog.

Thanks

 

[Mark44]

From post #55:

int main()
{    PersonInfo bob("Bob Faraday", 32);
    PersonInfo clone("clone", 44);
    clone = bob;//copy constructor
    <snip>

You really need to revise your code and your notes. The last line above is an assignment. The bob and clone objects have already been created, so that line doesn't involve any constructor. You should also move Nsize out of the class definition -- it doesn't belong there.

It would be a good idea for you to review the chapter in Gaddis that discusses constructors and operator overloads. Here's a short example

PersonInfo joe;  // Calls a default constructor, which you don't have - compiler error
PersonInfo bob("Bob Faraday", 32);   // Calls the constructor with two arguments - OK
PersonInfo fred(bob);   // Calls the copy constructor - OK
joe = fred;        // Calls operator=(), which you now have - OK

 

[yungman]

From post #55:

int main()
{    PersonInfo bob("Bob Faraday", 32);
    PersonInfo clone("clone", 44);
    clone = bob;//copy constructor
    <snip>

You really need to revise your code and your notes. The last line above is an assignment. The bob and clone objects have already been created, so that line doesn't involve any constructor. You should also move Nsize out of the class definition -- it doesn't belong there.

It would be a good idea for you to review the chapter in Gaddis that discusses constructors and operator overloads. Here's a short example

PersonInfo joe;  // Calls a default constructor, which you don't have - compiler error
PersonInfo bob("Bob Faraday", 32);   // Calls the constructor with two arguments - OK
PersonInfo fred(bob);   // Calls the copy constructor - OK
joe = fred;        // Calls operator=(), which you now have - OK

Thanks

That's what I've been doing the last week, revising the constructors, copy constructor and all that. I know it's important. I read through the two chapter again carefully.

That's another thing, I really don't know where to put variables like Nside. What is the rule where to put variables? I know you put in private if you don't want to change it by outside, but what's the difference between putting in public or outside the class definition? How do I know it doesn't belong there. It is more than I should or should not, Compiler sometimes gives error if it is put in the wrong place. I don't recall the book ever talk about this, it's like hit and miss for me!

Thanks for all your help. This C++ really get me on my weakest part...memorize all the rules, functions and all that. There are so so many rules. My memory is really deteriorating now, it's like in test if you call out 3 numbers and want me to repeat it, I might have problem remembering that now. I had test before that I can remember 10+ numbers. I would never past the cognitive test now! So many time you ask whether I read the replies from you guys...I did, just forgot! It's really a struggle. This is so different from electronics. The theory and stuffs in electronics are very difficult to understand, BUT we don't have a lot. Once you understand and practice, you can get good at it over time and not a whole lot to remember. This C++ have so many things to remember, anyone of them are easy, but just have so many. Like I have to keep reminding me to put const in the argument for Copy Constructor and Constructor for the rhs, then the Rule of Three. I spent a bigger part of yesterday struggling on the program that you called out I missed the Assignment. That's in the Rule of Three that I learn the day before and forgot!

It's like Calculus, You can sum up the first two semester in the front two pages and back two pages in most of the Calculus books. Hell, add another two pages, you can put the multi-variables 3rd semester in already. Try putting the essential stuffs of C++ in the first pages of the book, it's going to be a long one. Nothing difficult, just a lot of it. Pointers is one of the subject that doesn't have a lot to remember, but it has the twist and turn that it's difficult to really gets it.

In a way, C++ is good for me, really challenge my memory that I won't get if I keep working on electronics. Those I remember from before and have no problem remember and using them, I can do all the twisting and turning with it even now. But learning a completely new thing is something else. Just hope this brain exercise ( learning C++) is worth my while like doing physical exercise!

Thanks

 

[Mark44]

That's another thing, I really don't know where to put variables like Nside.

It's not really a variable, as it won't change when the program runs. Things like this are often called parameters (different from function parameters) or named constants. The proper place for it is outside the class, like up at the top of the program.
One style that is used a lot for named constants is ALL CAPS. That makes them really stand out in the code. Aside from this, Nside is not a good name to use, as it seemingly represents the number of sides on some geometric figure. A better choice would be MAX_NAME_LEN or something similar.

But learning a completely new thing is something else. Just hope this brain exercise ( learning C++) is worth my while like doing physical exercise!

Of course it is worth your while. The main reason I teach a class or two a year is to help exercise my brain. That's also why I work the NY Time crossword puzzle every day, as well as post here at PF. These activities help to exercise my brain and keep the neurons working.

 

[yungman]

It's not really a variable, as it won't change when the program runs. Things like this are often called parameters (different from function parameters) or named constants. The proper place for it is outside the class, like up at the top of the program.
One style that is used a lot for named constants is ALL CAPS. That makes them really stand out in the code. Aside from this, Nside is not a good name to use, as it seemingly represents the number of sides on some geometric figure. A better choice would be MAX_NAME_LEN or something similar.
Of course it is worth your while. The main reason I teach a class or two a year is to help exercise my brain. That's also why I work the NY Time crossword puzzle every day, as well as post here at PF. These activities help to exercise my brain and keep the neurons working.

Thanks

So if it is declared const, I should put in global?

Ha ha, try learning something that you don't know! Like what I am doing, C++ is so much more than Pascal, after like chapter 4, it's all new to me. That's the reason I take a break from electronics. My former company asked me to do a contract for a year and half in 2015, I did not miss a beat working. Then designed two guitar amps and then a few audiophile power amps successfully. Nothing is like learning C++ that I don't know. Electronics to me is more like muscle memory, a lot of it is automatic even thought it's in a different field. Maybe it's like you learning another language, it would be very easy as you already know how programming is.

I hope C++ can shake out more rust from my brain. My English is too bad to even try cross word puzzle.

 

[pbuk]

The proper place for it is outside the class, like up at the top of the program.

I don't agree with that - this constant is used to specify the length of class members that are C-strings so it shouldn't be plluting the global namespace. Namespacing it is one option but probably beyond the current level of expertise (!), otherwise I don't see anything wrong with making it a static const class member.

Edit: on second thoughts as this value is only used at compile time I would make it a macro e.g.

// PersonInfo.h
#define PERSON_INFO_STRING_LENGTH 25

 

[yungman]

From post #55:

int main()
{    PersonInfo bob("Bob Faraday", 32);
    PersonInfo clone("clone", 44);
    clone = bob;//copy constructor
    <snip>

You really need to revise your code and your notes. The last line above is an assignment. The bob and clone objects have already been created, so that line doesn't involve any constructor. You should also move Nsize out of the class definition -- it doesn't belong there.

...

I finished updating my notes on Constructor and Copy Constructor. Here is the copy of this part of my notes. Obviously I really packed the lines to make the code take up less space. It's for my own notes.

Thanks

 

[Mark44]

I finished updating my notes on Constructor and Copy Constructor. Here is the copy of this part of my notes.

The notes still have incorrect comments.

int main(){ PersonInfo bob("Bob Far", 32); PersonInfo clone("clone", 44); clone = bob;//copy constructor
bob.setName();//After copying clone = bob, change name of bob and see what happen to clone
bob.printB(); clone.printC(); return 0;}

The line clone = bob; is NOT calling a copy constructor. For about the fourth time, this code calls operator=().
The second highlighted comment above implies that you think clone changed because of a copy constructor.

Obviously I really packed the lines to make the code take up less space. It's for my own notes.

Why do you care about taking up less space? Packing everything in there makes it much harder for anyone, including you, to read and comprehend. Do yourself a favor and spread things out more.

 

[Vanadium 50]

The line clone = bob; is NOT calling a copy constructor. For about the fourth time, this code calls operator=().
The second highlighted comment above implies that you think clone changed because of a copy constructor

This may be a good case for over-commenting, because the comment makes the misunderstanding clearer.

yungman, this is covered on page 820 in Gaddis (6th edition). You may wish to review it.

 

[Vanadium 50]

to add:

Is it clear what the difference here is between o2 and o3 and how they are filled?

Object o1, o2;
o2 = o1;
Object o3 = o1;

 

[yungman]

The notes still have incorrect comments.

The line clone = bob; is NOT calling a copy constructor. For about the fourth time, this code calls operator=().
The second highlighted comment above implies that you think clone changed because of a copy constructor.
Why do you care about taking up less space? Packing everything in there makes it much harder for anyone, including you, to read and comprehend. Do yourself a favor and spread things out more.

//The copy constructor must be left from old notes, I understand perfectly clone = bob is assignment. I emphasis in my notes of the Rule of Three. That's where it's important, to use Copy Constructor and Assignment if there is pointer in the class.

I know perfectly well Copy Constructor ONLY help with copying class object with pointers, that Copy Constructor will copy pointers that points to a different address.You know I am talking about in my notes I cramp lines together, not in the program? I don't want my notes as thick as a book.

 

[Vanadium 50]

I know perfectly well Copy Constructor ONLY help with copying class object with pointers, that Copy Constructor will copy pointers that points to a different address.

That's not true.

There are other cases - suppose you have a member that is the time of creation of that object. It's the programmer's decision on whether he wants this time updated or not when the object takes on a new value. A custom copy constructor and/or a custom assignment operator would be the way to do this.

 

[Mark44]

//The copy constructor must be left from old notes, I understand perfectly clone = bob is assignment. I emphasis in my notes of the Rule of Three.

These are the notes that you updated several times. If you make notes, it's important to keep them up-to-date. Otherwise, you'll look at the notes again in a month or six months, and make the same mistake again.

You know I am talking about in my notes I cramp lines together, not in the program? I don't want my notes as thick as a book.

You pack lines together in the programs you show, as well. IMO, your notes are not as helpful as they could be, with all the code in bold and in lots of different colors. When you emphasize everything, then nothing stands out.
Your call -- you can have a thin set of notes that is almost unreadable, or you can space things out a bit, to make them readable and therefore useful, at the cost of a few more pages.

If you really want to squeeze stuff in, you could change the font size in Word to 4 points...

 

[yungman]

You pack lines together in the programs you show, as well. IMO, your notes are not as helpful as they could be, with all the code in bold and in lots of different colors. When you emphasize everything, then nothing stands out.
Your call -- you can have a thin set of notes that is almost unreadable, or you can space things out a bit, to make them readable and therefore useful, at the cost of a few more pages.

If you really want to squeeze stuff in, you could change the font size to 4 points...

I can read my notes just fine, To be honest, I like program packed, I have more issue flipping pages to read a program than packing everything in one page. I can honor what you said if I post program here, I need to space it out so people can read better. But if I write program for myself to read, I still like to pack it for my reading. I will space it out before I post here, but I am still for packing.

Remember the notes are for me to read.

 

[Mark44]

Remember the notes are for me to read.

Not when you post them here. To be honest, the notes you posted in this thread are awful -- too packed, too much bold, too much color.

 

[yungman]

That's not true.

There are other cases - suppose you have a member that is the time of creation of that object. It's the programmer's decision on whether he wants this time updated or not when the object takes on a new value. A custom copy constructor and/or a custom assignment operator would be the way to do this.

Thanks

I am sure there are a lot more to this. So far, I only go by Gaddis book that emphasize on copying pointers but point to different addresses. Just have to learn as it comes. As good as Gaddis's book, it only cover one specific case for each topic, it doesn't cover all cases. I know from the get go that going through just the examples in the book is not even close to enough to learn. That's the reason I spent so much time working on c-string, passing around like in this thread and a few others. Gaddis mostly using int and float to pass around which is a LOT easier than c-string names and all that.