C++ Why the loop going in infinite loop?

[Raghav Gupta]

Homework Statement

I have to find GCD or HCF of two numbers.

Homework Equations

The Attempt at a Solution

#include<iostream.h>
#include<conio.h>
void main()
{
    clrscr();
    int i,m,n,temp;
    cout<<"Enter two numbers\n";
    cin>>m>>n;
    do
    {
    if(n>m)
    {
     temp=n;
     n=m;
     m=temp;   // this loop I think it is correct but still it is going to an infinite loop.
    }
     i=n;
     if(m%i==0&&n%i==0)
     break;
     i--;
    }while(i>=1);
    cout<<"The HCF is\t"<<i;
    getch();
}

 

[Dr. Courtney]

Use some printf statements for debugging (or cout)

See if your code is doing what you think it is doing.

I usually define a debug flag and have debugging statements such as

if(debug) printf("%d %d\n", num, num2);

etc

 

[NascentOxygen]

Where you give i its starting value, you have incorrectly placed the statement so that it is executed during every pass through the loop. You should place it where it gets executed once only.

 

[Raghav Gupta]

Where you give i its starting value, you have incorrectly placed the statement so that it is executed during every pass through the loop. You should place it where it gets executed once only.

Thanks,
Now I am able to execute and get correct output.
My code looks like this now,

#include<iostream.h>
#include<conio.h>
void main()
{
    clrscr();
    int i,m,n,temp;
    cout<<"Enter two numbers\n";
    cin>>m>>n;
    i=n;

    do
    {

      if(m%i==0&&n%i==0)
      break;
      i--;
    }while(i>=1);
     cout<<"The HCF is\t"<<i;
     getch();
}